fix(search): Add end date for last 7 and last 30 days - #62375
Conversation
|
/compile amend / |
|
/backport to stable34 |
|
/backport to stable33 |
There was a problem hiding this comment.
Pull request overview
This PR aims to complete unified search date-range requests by ensuring the “Last 7 days” and “Last 30 days” presets set an explicit end date (until), which is required by the CalDAV recurring-event expansion logic referenced in #60766.
Changes:
- Update
UnifiedSearchModalquick date ranges to set anendAtvalue for7daysand30daysfilters. - Regenerate a large set of
dist/bundles and correspondingdist/*.licensemanifests.
Reviewed changes
Copilot reviewed 1 out of 228 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/components/UnifiedSearch/UnifiedSearchModal.vue | Adds endAt for “Last 7 days” / “Last 30 days” quick date ranges so until can be sent. |
| dist/workflowengine-workflowengine.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/weather_status-weather-status.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/updatenotification-view-changelog-page.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/updatenotification-updatenotification.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/updatenotification-update-notification-legacy.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-users-management.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-personal-webauthn.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-personal-security.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-personal-password.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-personal-info.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-admin-sharing.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-admin-settings-presets.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-admin-security.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-admin-overview.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-admin-mail.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-admin-delegation.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-admin-basic-settings.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-vue-settings-admin-ai.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-main.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/settings-declarative-settings-forms.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files-sidebar.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files-settings-personal.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files-settings-admin.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files-search.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files-reference-files.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files-main.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files-init.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files_sharing-public-nickname-handler.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files_sharing-personal-settings.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files_sharing-init.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files_sharing-init-public.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files_sharing-files_sharing_tab.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files_sharing-collaboration.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/files_sharing-additionalScripts.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/dashboard-main.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-update.js | Regenerated compiled bundle (chunk hashes/source map query changed). |
| dist/core-unsupported-browser.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-unified-search.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-recommendedapps.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-public-page-user-menu.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-public-page-menu.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-public_share_auth.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-main.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-login.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-login_flow.js | Regenerated compiled bundle (chunk hashes/source map query changed). |
| dist/core-legacy-unified-search.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-install.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/core-common.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/9906-9906.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/9811-9811.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/9811-9811.js | Regenerated compiled chunk. |
| dist/9553-9553.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/9150-9150.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/8582-8582.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/853-853.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/853-853.js | Added a new compiled chunk. |
| dist/8374-8374.js | Removed a compiled chunk. |
| dist/8192-8192.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/7859-7859.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/7497-7497.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/6798-6798.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/6798-6798.js | Regenerated compiled chunk (module reference changed). |
| dist/6597-6597.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/6505-6505.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/5037-5037.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/4723-4723.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/428-428.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/4271-4271.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/4271-4271.js | Regenerated compiled chunk. |
| dist/4254-4254.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/3486-3486.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/2457-2457.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/2426-2426.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/2311-2311.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/1991-1991.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/1930-1930.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/1764-1764.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/1764-1764.js | Regenerated compiled chunk. |
| dist/1604-1604.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/1598-1598.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/1035-1035.js.license | Regenerated license manifest (dependency/version list changed). |
| dist/1035-1035.js | Regenerated compiled chunk. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e8c541b to
9d8801c
Compare
9d8801c to
0b8039d
Compare
|
/compile / |
DerDreschner
left a comment
There was a problem hiding this comment.
Tested successfully 👍
|
/compile / |
|
/compile rebase |
a5e5842 to
8d29f8b
Compare
|
/compile rebase |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
8d29f8b to
781d166
Compare
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/62375/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 95a02993 781d1666
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62375/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Found while working on #60766
It also a bit of per-requirement.
The unified search allows to filter for today, the last 7 day, last 30 days, this year, last year, and a custom date range.
For last 7 and last 30 the end date (=> until parameter) was not set. That's not an issue for files or talk because there we just select every file mtime or message timestamp larger than x via sql.
For calendar events the actual expansion of an recurring event happens at php level and currently requires a start and end date. I'm going to add some defaults to #60766 (since set, until missing => max date; since missing, until set => 0), but better would be to send a complete request.
How to test:
Checklist
3. to review, feature component)stable32)AI (if applicable)